@MariaAga how much work would it be to mark the date and time fields as incorrect? Also, I vaguely recall the form actively checking that the date is in the future. Has it stopped working in the meantime or am i misremembering?``

We have it only for starts before, we can probably easliy copy it to starts after as well

@pafernanr could you please add the last newline so that the linter is happy?

I'll review failed CI jobs probably along this week.

@pafernanr ping

Hi, sorry for late response.
I was checking the tests and I think the culprit is https://github.com/theforeman/foreman-tasks/blob/master/test/unit/triggering_test.rb#L12

If I understand it well, that test is exactly executing a job in the past (-120). Dunno why, could be past-times needed for any reason?

If I understand it well, that test is exactly executing a job in the past (-120). Dunno why, could be past-times needed for any reason?

I can't think of anything. The only thing we did there was that jobs scheduled for the past started as soon as possible, making them essentially the same as immediate jobs

In that case I removed that test line as it is no longer needed. Executing past dates returns an error which make Unit test to fail.

hmm, I thought it is better idea to keep the test but modifying it in order to check pasta start_at dates returns false. Please check triggering_test.rb. Does it makes sense for you?